-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Aesara dependency #5757
Update Aesara dependency #5757
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5757 +/- ##
=======================================
Coverage 88.95% 88.95%
=======================================
Files 74 74
Lines 13811 13811
=======================================
Hits 12286 12286
Misses 1525 1525 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛳 it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, wait. That failing test looks like a new bug?
Aesara issue opened: aesara-devs/aesara#955 |
Can we xfail or is this critical? |
Looks like some kind of tensor typing problem:
|
No need to guess guys, there's a linked issue: aesara-devs/aesara#955 |
This should only show up as a warning under normal aesara flags, and only in some edge cases. It will be fixed in a future release but for now I think it's fine to temporarily xfail |
8035f67
to
13b05f1
Compare
The test that is failing will be removed in #5806, it was not easy to turn it off due to the way it is parametrized. In the meantime I rebased from main to see if anything else fails. |
Seems still broken, or another test? |
It's the same test, it will be removed in #5806, then we can rebase and it should be good to go. |
13b05f1
to
ebdc1e1
Compare
No description provided.